refactor(api): Update remaining webhook routes to modular structure #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/slack-report-exemptions
branch
from
2f33404 to
ad08273
Compare
DafyddLlyr
changed the title
DafyddLlyr
force-pushed
the
dp/webhooks-api-next
branch
from
b9babd2 to
7279188
Compare
DafyddLlyr
force-pushed
the
dp/webhooks-api-next
branch
from
9243b20 to
409d2ca
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/webhooks-api-next
branch
from
eeed25d to
d94b65e
Compare
DafyddLlyr
commented
Oct 4, 2023
| @@ -25,13 +25,18 @@ type RequiredScheduledEventArgs = Pick< | |||
| "webhook" | "schedule_at" | "comment" | "payload" | |||
| >; | |||
|
|
|||
| export interface ScheduledEventResponse { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Typing this cascaded across a few functions and tests which is a bit noisy for a PR, but quite nice in practice.
DafyddLlyr
commented
Oct 4, 2023
| @@ -14,9 +17,9 @@ enum Destination { | |||
| } | |||
|
|
|||
| interface CombinedResponse { | |||
There was a problem hiding this comment.
This type is repeated in api.planx.uk/send/createSendEvents.ts but I'm ignoring this for now as this PR is already bigger than it should be.
DafyddLlyr
commented
Oct 4, 2023
| payload: payload, | ||
| comment: `expiry_${payload.sessionId}`, | ||
| }); | ||
| return [response]; |
There was a problem hiding this comment.
Returning [response] as opposed to just response gives us a consistent return type across all these APIs.
DafyddLlyr
changed the title
jessicamcinchak
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/webhookroutes to format proposed here